New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

placing notes on ACL IP's #206

Closed
wispr opened this Issue Apr 18, 2015 · 7 comments

Comments

Projects
None yet
2 participants
@wispr

wispr commented Apr 18, 2015

Thinking about ACL's to allow outside access to resources and that it would be handy to be able to put a comment in for each IP address that is in an ACL to note a customer, specific resource, etc, that needs access to the given ACL. Could be beneficial to use something like that zone UI to list each ACL entry with options, like enabled, disabled, comment, etc?

@WillyXJ

This comment has been minimized.

Owner

WillyXJ commented Apr 20, 2015

I'm not sure I quite understand your last sentence - could you please elaborate?

Also, ACL entries can support comments in the comment box - is this not sufficient?

@WillyXJ WillyXJ added the fmDNS label Apr 20, 2015

@wispr

This comment has been minimized.

wispr commented Apr 22, 2015

Correct, the ACL group can have a comment against all of the IP addresses that might belong to a given ACL. I'd like to see comments for each IP address or range inside of the ACL. Imagine a customer ACL list, with a dozen IP addresses in it. I'd like to be able to comment on each IP address with the customer name or code of who the IP address belongs to.

The existing text box wouldn't allow you to enter a comment for each IP address. It'd need a new UI of some type for the ACL. In the perfect world in my head, you could reuse the existing UI from zone management and treat each IP address like an RR inside of a zone.

@WillyXJ

This comment has been minimized.

Owner

WillyXJ commented Apr 22, 2015

Thanks for the clarification. I'll have to play around with this idea.

In the meantime, you could handle you comments similar to this idea:

image

@wispr

This comment has been minimized.

wispr commented May 11, 2015

The downside to the workaround suggested above is that we generally use the comment field for meaningful information on the main acl page so we can quicky scroll through the rules and know what each is for.

@WillyXJ

This comment has been minimized.

Owner

WillyXJ commented Dec 3, 2015

I'm hesitant to expand the ACL page like you suggest as it may end up complicating several pieces. However, would something like this work for your needs (if it were supported)? I'm assuming you'll probably want to see your ACLs and comments all in one line. :)

image

@WillyXJ WillyXJ modified the milestone: 3.0 release Dec 4, 2015

@wispr

This comment has been minimized.

wispr commented Dec 15, 2015

Yeah, that could probably work, but might make your life more
complicated....

Robbie Wright
Siuslaw Broadband https://siuslawbroadband.com
541-902-5101

On Thu, Dec 3, 2015 at 3:26 PM, WillyXJ notifications@github.com wrote:

I'm hesitant to expand the ACL page like you suggest as it may end up
complicating several pieces. However, would something like this work for
your needs (if it were supported)? I'm assuming you'll probably want to see
your ACLs and comments all in one line. :)

[image: image]
https://cloud.githubusercontent.com/assets/1309591/11577367/634f692e-99da-11e5-8439-4a84468d6899.png


Reply to this email directly or view it on GitHub
#206 (comment)
.

WillyXJ added a commit that referenced this issue Feb 24, 2016

fmDNS - #206 - Reworked the ACL configuration page
Reworked the ACL configuration page to support additional comments on
each ACL element.
@WillyXJ

This comment has been minimized.

Owner

WillyXJ commented Feb 24, 2016

Reworked the approach and implemented a solution similar to the zones listing with clones. Feature added to the v3.0 dev branch. Will be available in 3.0-alpha1 and beyond.

@WillyXJ WillyXJ closed this Feb 24, 2016

@WillyXJ WillyXJ modified the milestones: 3.0 release, 2.x release Apr 8, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment