Debug the CSS 3 transitions dectection function - Now fallback is fired #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thinking this code back, I'll update it to make sur the transition detection is cached in a var so that the script don't have to run each time it's called. |
|
This is great! Just tested your pull request and it fixes the fallback in IE8/9. |
…ding a false positive is resolved) But: 1- Each new carousel gonna re-launch the test 2- The Snapback plugin still has it's own transitionSupport test Would be better in the futur if we merge all those test in it's own object for example. I don't have much time right now to work on this, so if anyone want to take relay, go ahead. Still, at least the initial bug is resolve.
|
Thanks a lot friend. I solved my IE 8/9 issue. 👍 |
|
Issue #79: Slides not sliding in IE 8 and IE 9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an issue bypassing the CSS 3 transitions fallback in older browser.
So I've changed transitionSupport() function with adaptaton of Modernizr project cssTransitions detection rules.