Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[issue] winmergeu and Windows Explorer integration does not behave as expected #908

Closed
1000p opened this issue Aug 2, 2021 · 11 comments
Closed

Comments

@1000p
Copy link

1000p commented Aug 2, 2021

Calling winmergeu "path_to_file_1" "path_to_file_2" WinMege opens, but closes immediately after window appears.
This is happening with the Windows Explorer integration using WinMerge shortcut.

When calling with parameter "/u" (winmergeu /u "path_to_file_1" "path_to_file_2") WinMege behaves as expected (window stays open).
Is there a way to edit registry so opening WinMerge through the shortcut would add the parameter on the call ?

Param. docu.
/u
Prevents WinMerge from adding either path (left or right) to the Most Recently Used (MRU) list. External applications should not add paths to the MRU list in the Select Files or Folders dialog.

@sdottaka
Copy link
Member

sdottaka commented Aug 2, 2021

Is there a way to edit registry so opening WinMerge through the shortcut would add the parameter on the call ?

Unfortunately, it doesn't have that feature.

I couldn't reproduce this issue.

If the WinMerge window appears and closes immediately, it's possible that WinMerge has crashed.

If you add the /u command line option, when WinMerge is started, the history will not be registered in the Jump list that exists from Windows 7 or later, and it will not be registered in the registry. It may have crashed with either registration.

I have a few questions.

  1. Will this issue occur if you specify other files?

  2. What version of Windows are you using?

  3. What version of WinMerge are you using?

  4. If your OS is Windows 10, turn off "Show recently opened items in Jump Lists on Start or the taskbar and in File Explorer Quick Access" in Start → Settings → Personalization → Start as shown below. After that, does the problem occur?

image

  1. After using Regedit and changing Files in the registry key HKEY_CURRENT_USER\SOFTWARE\Thingamahoochie\WinMerge\Files to another name, does the problem occur?

image

@1000p
Copy link
Author

1000p commented Aug 2, 2021

@sdottaka
It appears that there are no errors. At least none are shown. Here a screenshot that I managed to capture just before it quits:
image
(The red arrows point that there are 2 differences

1: It occurs with any kind of files. (comparable files)
2: This is a tricky one. I actually got an "aha.." moment when you asked that. WinMerge is running on Amazon Workspaces virtual environment. In system information I have: Microsoft Windows Server 2016 Datacenter 10.0.14393 Build 14393. Probably that's the reason behind the behavior.
3: WinMerge version is 2.16.12.0
4: That did not helped unfortunately.
5: If correctly understood (I have renamed "Files" to "AnyName") that did not changed anything.

@sdottaka
Copy link
Member

sdottaka commented Aug 3, 2021

Hmm, I tried Amazon Workspaces, but I couldn't reproduce it.

image

Is this a problem that has never happened before? Or is it happening from the beginning?

Please let me know if you know the conditions under which the problem occurs.

@1000p
Copy link
Author

1000p commented Aug 3, 2021

I have just started using WinMerge.
It is happening right from the installation. As of writing this I made a complete reinstall of the tool. After the installation the first run of the WinMerge was successful (not closed in a glimpse) second and any consecutive execution lead to the problem described. (Tested 2 times after each uninstall cycle I have restarted the VM.)

@kruess
Copy link

kruess commented Aug 23, 2021

Hi, same behaviour here on a WinSrv2019. Whenever I use the shell integration or adv. shell integration functions and winmerge should directly jump to the comparison window (no file selection dialog), it crashes immediately.
Exporting the settings and importing it on my WinSrv2012r2 or W10 does not show that behaviour.
I'm observing this on 2.16.12.0 & 2.16.14.0 - haven't tried the older versions, yet.
#908 & #913 seem to be equal.

sdottaka added a commit that referenced this issue Aug 23, 2021
@sdottaka
Copy link
Member

Could someone please replace the installed WinMergeU.exe (C:\Program Files\WinMerge) with WinMergeU.exe included in WinMerge-x64.zip at the bottom of the following web page to reproduce the problem?

https://github.com/WinMerge/winmerge/actions/runs/1158489761

image

When you run this WinMergeU.exe, %TEMP%\issue_908_913.log file will be created. Please attach this file.

@kruess
Copy link

kruess commented Aug 23, 2021

okay, here you are.
issue_908_913.log

sdottaka added a commit that referenced this issue Aug 23, 2021
@sdottaka
Copy link
Member

@kruess

Thank you for attaching the file.
Other people have attached the log(#913), but the output of the files is completely different and I am confused.

@kruess
Copy link

kruess commented Aug 23, 2021

Mine still looks different. I'm selecting two files in Windows Explorer and then I do an 'compare' on the advanced shell integration pop-up. Winmerge will start and close immediately after doing so.
issue_908_913.log

@sdottaka
Copy link
Member

@kuess Thank you!

sdottaka added a commit that referenced this issue Aug 25, 2021
sdottaka added a commit that referenced this issue Aug 25, 2021
@sdottaka
Copy link
Member

Fixed in commit f6abd30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants