Fixed processing that uses GetAsyncKeyState(). #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed the behaviour in the function CMainFrame::OnDropFiles() that when drag and drop is performed after pressing the control key, it behaves as if drag and drop is performed while pressing the control key. - Fixed the behaviour in the function CImgMergeFrame::OnChildPaneEvent() that when an arrow key is pressed after pressing the shift key or control key, it behaves as if the arrow key is pressed while pressing the shift key or control key.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the function CMainFrame::OnDropFiles(),
!!::GetAsyncKeyState(VK_CONTROL)is true not only when the control key is pressed, but also when the control key is not pressed but has been pressed since the last GetAsyncKeyState () was executed.So, for example, the "Include subfolders" option is applied with the reverse settings when the following steps are performed, which does not seem to be the expected behavior.
Step 1. Open the directory containing the directory to be compared by WinMerge in Explorer.
Step 2. Press the control key once.
Step 3. Select a range of two directories to enter with the mouse. (The control key is not pressed at this time.)
Step 4. Drag and drop the selected directories to WinMerge. (The control key is not pressed at this time.)
Similarly, in the function CImgMergeFrame::OnChildPaneEvent(), when an arrow key is pressed after pressing the shift key or control key, it behaves as if the arrow key is pressed while pressing the shift key or control key.
This PR fixes these behaviors.