Strip known bad character sequence before parsing #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bad character sequence leads to the whole response failing to parse. Specifically this is the [substitute character][1] and is not valid for use in XML. Therefore, this change should be safe, or at least lead to a preferable outcome to outright failure. [1]: https://en.wikipedia.org/wiki/Substitute_character
Removes all the non-printable characters excluded from the XML [characters specification][1]. [1]: https://www.w3.org/TR/xml/#charsets
|
We've had this live for a few days now and the related errors have disappeared. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bad character sequence leads to the whole response failing to parse.
Specifically this is the substitute character and is not valid for
use in XML. Therefore, this change should be safe, or at least lead to a
preferable outcome to outright failure.
Related issues: #166 #219