rust stat should call libc stat #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n-salim
reviewed
Sep 20, 2019
There was a problem hiding this comment.
BTW this issue was already being tracked by https://jira.wrs.com/browse/V7LIBC-980 . Glad it fixes some test cases.
n-salim
approved these changes
Sep 20, 2019
|
@BaoshanPang @n-salim I sadly can't find any other way to contact you (email, etc.). Is WindRiver recruiting Rust developers? I'm currently between jobs in Munich and would love to work on Rust / VxWorks in the automotive field. |
Not sure, but please e-mail me at salim at windriver dot com (you know what I mean!) and we can discuss it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes two test cases pass:
test fs::tests::create_dir_all_with_junctions ... ok
test fs::tests::symlinks_work ... ok
r? @n-salim