Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Padding #7

Closed
lorenzo-gomez-windhover opened this issue Nov 4, 2020 · 2 comments
Closed

Padding #7

lorenzo-gomez-windhover opened this issue Nov 4, 2020 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@lorenzo-gomez-windhover
Copy link
Collaborator

lorenzo-gomez-windhover commented Nov 4, 2020

Padding cannot be extracted directly from the DWARF. It becomes even more complex when structures have bit fields. It's not an impossible task, but assumptions and scope of padding capabilities need to be concretely defined since any incorrect behavior caused by padding logic can compromise the correctness of the database. And therefore compromise the reliability of any ground system using juicer.

This will be a work-in-progress for now. Might create a new branch dedicated to solving padding.

@lorenzo-gomez-windhover lorenzo-gomez-windhover added the enhancement New feature or request label Nov 4, 2020
lorenzo-gomez-windhover added a commit that referenced this issue Nov 5, 2020
…have bitfields are ignored for now. Partially addresses #7.
@lorenzo-gomez-windhover
Copy link
Collaborator Author

UPDATE: For symbols that do not have any bitfields, padding at the end of structures is added. The padding field is given the name of _spare_end.

TODO: Document these changes.

lorenzo-gomez-windhover added a commit that referenced this issue Nov 5, 2020
…ded to structures that don't have bitfields. Partially addresses #7.
@lorenzo-gomez-windhover
Copy link
Collaborator Author

UPDATE: Support for padding in between fields of a structure has been added.

TODO:Add support for padding in structures that have bitfields. This should be handled almost the same way as structures without bitfields, however, the fields should be sorted by offset as these offsets may not follow ascending order when there is a bitfield inside a structure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant