v0.8.4 #143
Merged
v0.8.4 #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the Id parameter to New-BTHeader was mandatory however as it can be a generated unique string it doesn't have to be. This commit modifies the Id parameter so it is no longer mandatory and uses a GUID style string as the autogenerated Id if none is passed. GUIDs are used instead of, say, the title because they are guaranteed to be unique whereas using the title or date/time could cause notification Id collisions. This commit also adds a test to ensure that the function can be called without the -Id parameter and that it is actually generated, not left as null or an empty string.
(GH-125) Make Header ID optional
Adding feature to handle HeroImage
…cation_cmdlet Add AppId parameter to New-BurntToastNotification cmdlet
Codecov Report
@@ Coverage Diff @@
## main #143 +/- ##
==========================================
- Coverage 59.29% 59.17% -0.13%
==========================================
Files 1 1
Lines 457 463 +6
Branches 3 3
==========================================
+ Hits 271 274 +3
- Misses 183 186 +3
Partials 3 3
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.