add user_pcall variant that doesn't throw #2315
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested using your example code and it no longer failed.
test1.lua:
test2.lua:
I toggle between the two using
gs load test1
orgs load test2
. Can check which file is loaded (or if both are somehow loaded) by togglinggs debugmode
on and usinggs eval print(user_env.a, user_env.b)
Before this patch, it fails to unload test1 and
a
always takes a value of 10. After the patch, it does successfully unload test1 and loads test2, so a goes to nil and b goes to 10. Swapping back and forth results in the expected changes.