Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

further development and modifications #1680

Closed
5 tasks done
jp-weber opened this issue Dec 18, 2018 · 4 comments
Closed
5 tasks done

further development and modifications #1680

jp-weber opened this issue Dec 18, 2018 · 4 comments
Assignees
@jp-weber

Comments

@jp-weber
Copy link
Member

jp-weber commented Dec 18, 2018 •
edited

In the last time I think about the further development from T10, specifically Template10.Extras.16299.
With the new release of Prism.Windows we can switch from our Prism implementation to the official implementation and can set obsolete our Prism imlementation. The second minor point is the release of the WinUI library, it is now possible to get for older Win10 versions and sdks, the new versions of the controls.

I would therefore suggest to take the NavView through the nuget package, so we don't have to consider dependency properties on the SDKs anymore.

https://github.com/Microsoft/microsoft-ui-xaml

  • switch to Prism.Windows / Prism.Windows.Unity

  • rename Template10.Extras.16299 to Template10.NavView or NavigationView

  • add Windows UI Library to Template10.NavView

  • set min sdk target from Template10.NavView to 1703

  • update template sample to support Template10.NavView with Windows UI Library
@deRightDirection
Copy link

where can I find the template10.extras.16299 on nuget?

@jp-weber
Copy link
Member Author

This is not yet available at nuget. Currently you must add the library to your project.

I have adapted the Template10.Extras.16299 locally and already published an app with it. If there exists a request, I will upload it.

@JerryNixon
Copy link
Member

I thought I would have seen your PR for this by now.

@JerryNixon JerryNixon pinned this issue Feb 6, 2019
@jp-weber
Copy link
Member Author

jp-weber commented Feb 6, 2019

I will create a pull request in the next days for it👌

jp-weber added a commit to jp-weber/Template10 that referenced this issue Feb 7, 2019
@jp-weber
implement Windows-XAML#1680
93b2f1d
jp-weber added a commit to jp-weber/Template10 that referenced this issue Feb 8, 2019
@jp-weber
improve implement Windows-XAML#1680
ad75f90
JerryNixon pushed a commit that referenced this issue Mar 14, 2019
@jp-weber @JerryNixon
[WIP 🚧] PR for #1680 (#1683)
c69b04f 
* Extended TryFindItem() with parameter to to distinguish between multiple settings pages.

* Fix GoForwardAsync, the last stack entry is taken now.

*  Allow setting the NavViewEx selected item without

performing navigation. This is sometimes necessary to properly set the initially selected item.

/by TastesLikeTurkey

* Change uri to string (NavViewEx/SettingsNavigationUri)

So the same input is possible as for a normal navigaton page. In this case with SettingsNavigationUri="SettingPage".

* implement #1680

* improve implement #1680

* Update NavViewEx.cs

If navigation is canceled or incorrect, the previous NavigationViewItem (or no) is set again.
@JerryNixon JerryNixon unpinned this issue Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jp-weber jp-weber

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JerryNixon @jp-weber