tests/shell-checks: add bashate

Winetricks · Jun 15, 2017 · 9376945 · 9376945
1 parent d0ed5bb
commit 9376945
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/README.md b/README.md
@@ -33,7 +33,7 @@ load_iceweasel()
 Note that the filename and command name (icecat) must match. All metadata fields are optional, only command name and category required.
 
 # Tests
-The tests need `checkbashisms` and `shellcheck>=0.4.4` installed.
+The tests need `bashate`, `checkbashisms`, and `shellcheck>=0.4.4` installed.
 Makefile supports a few test targets:
 * check - runs './tests/winetricks-tests quick' (without first clearing $WINETRICKS_CACHE)
 * shell-checks - runs './tests/shell-checks'

diff --git a/tests/shell-checks b/tests/shell-checks
@@ -60,4 +60,11 @@ do
 
     echo "Checking ${shellscript} with shellcheck:"
     w_try shellcheck -s sh "${shellscript}"
+
+    echo "Checking ${shellscript} with bashate:"
+    # Can't ignore individual things for now, filed bug:
+    # https://bugs.launchpad.net/bash8/+bug/1698088
+    # E003=indent spacing check
+    # E010=do/while same line (in some perl in winetricks)
+    w_try bashate -i E003,E010 "${shellscript}"
 done