New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vcrun2015, 2017 and 2019 are broken (ucrtbase is removed prior to running installer) #1736
Comments
Thanks for the report @gverm. Do you want to attempt a fix? If not, I can, but it will likely be a week or two before I do. If you don't have time, it would be helpful if you could include the context from IRC (I don't know that I was online at the time). |
FWIW, I suspect this broke more than vcrun*. When I ran the tests last night, I noticed breakage in some other apps, in particularly galliumnine (but didn't investigate, as I've noticed that 6.4/6.5 have have various breakages). I ended up using 5.0 / 6.0 instead to get a better idea of what was broken on the wine versus winetricks side. While I have no problem fixing things on the winetricks side when needed, I don't have as much time lately for the wine side. As a result, I don't have as much time/interest investigating if regressions are wine bugs or newly intended behavior. |
@austin987 I was planning on having a look at the vcrun* stuff later this week. I've pasted the IRC convo below, hopefully that helps. As for other regressions, a lot of them were reported and fixed, some after 6.5, so 6.6 should be a better release.
|
I'm using the winetricks-git package on Arch (the sha256sum shows as |
a new snapshot is needed for a fix, this is really bad in terms of crashing peoples prefixes beyond repair |
…e 6.6 Summary: Ref: Winetricks/winetricks#1736 Test Plan: Tested installing vcrun2015, vcrun2017, and vcrun2019 in new wine prefixes Reviewers: #triage_team, DataDrake Reviewed By: #triage_team, DataDrake Subscribers: DataDrake Differential Revision: https://dev.getsol.us/D10913
Some change (can't seem to be able to bisect because of unrelated problems) after wine-6.5 is breaking the vcrun verbs that remove ucrtbase before running the installer.
According to Julliard (on IRC) this is to be expected with the recent loader changes, so we'll have to find another way to fix it.
I would suggest instead of removing ucrtbase, extracting it from the setup and replacing builtin before running the setup.
The text was updated successfully, but these errors were encountered: