New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Native font names replacements related improvements #1085
Conversation
7b73fd5
to
c269b6b
Compare
add_register_font_replacement_unicode.txt The Unicode registry file makes the task simpler. |
Good idea, but unfortunately it doesn't work with |
Replace "\xff\xfe" with "\377\376". I hope this will be your work. |
c269b6b
to
ff63c13
Compare
I modified Now the implementation is locale-independent and |
src/winetricks
Outdated
w_register_font_replacement() | ||
{ | ||
_W_alias=$1 | ||
shift | ||
_W_font=$1 | ||
# UTF-16 BOM (U+FEFF, "0xEF 0xBB 0xBF" in UTF-8) | ||
printf "\357\273\277" | iconv -f utf8 -t utf16le > "$W_TMP"/_register-font-replacements.reg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like BSD doesn't support utf8/utf16le; it uses UTF-8/UTF-16LE (not sure what mac does, but that should be verified as well).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We create UTF-16 (little endian) .reg file with BOM (U+FEFF) and convert UTF-8 font names to UTF-16 little endian.
ff63c13
to
bdf080e
Compare
I merged 3/4 commits, fakechinese now has a conflict that can be addressed as its own PR. Sorry this took so long, I wasn't clear on how to test it before. |
Fixes #781 and potential problems in
fakejapanese*
verbs.Set proper locale when runningregedit
(w_register_font_replacement
)Change existing variable names infakejapanese*
Unset local variables infakejapanese*
w_register_font_replacement()
and pass native font names infakejapanese*
fakejapanese