mtg_arena: new verb

[Kreyren]

DO NOT MERGE - Game was updated and this no longer works.

Adds Magic: The Gathering Arena verb

Referencing: PhoenicisOrg/scripts#934

game using non-visualstuio installer works with output that doesn't seem to be relevant to WINE:

Executing wine msiexec /I /home/kreyren/.cache/winetricks/mtg_arena/MTGAInstaller_0.1.1790.733462.msi

Z:\home\kreyren>chcp 65001
Can't recognize 'chcp 65001 ' as an internal or external command, or batch script.

Z:\home\kreyren>del "C:\users\kreyren\Temp\{CE5264CC-7EDF-492E-84F6-B9E7A53A606A}.bat" /Q /F
Can't recognize 'C:\users\kreyren\Temp\{CE5264CC-7EDF-492E-84F6-B9E7A53A606A}.bat' as an internal or external command, or batch script.

Official uses visualstudio installer

• returns 0070:err:msi:custom_get_thread_return Invalid Return Code 1627 for https://mtgarena.downloads.wizards.com/Live/Windows32/MTGAInstaller.exe
• winebug https://bugs.winehq.org/show_bug.cgi?id=47820, logic adapted

Uses: #1348

Signed-off-by: Jacob Hrbek kreyren@rixotstudio.cz

[Kreyren]

Results in:

which is fatal

Update: affected by https://bugs.winehq.org/show_bug.cgi?id=45546

Update: Patched using #1348 using WINEHACK

[Kreyren]

Lutris installer

Source of lutris installer which is written based on this commit
https://lutris.net/games/install/15855/view

custom-name: Magic The Gathering Arena - AppImage
files:
- setup: https://mtgarena.downloads.wizards.com/Live/Windows32/versions/1790.733462/MTGAInstaller_0.1.1790.733462.msi
- appimage_ci: https://github.com/Kreyren/kreytricks/releases/download/7f230d2/MTGA.AppImage
game:
  args: wine "$GAMEDIR/drive_c/Program Files (x86)/Wizards of the Coast/MTGA/MTGA.exe"
  exe: $GAMEDIR/MTGA.AppImage
installer:
- move:
    dst: $GAMEDIR
    src: appimage_ci
- execute:
    args: wine wineboot
    description: Setting up wine prefix
    env:
      WINEARCH: win64
      WINEPREFIX: $GAMEDIR
    file: $GAMEDIR/MTGA.AppImage
- execute:
    args: wine setup
    description: Installing MTGA
    env:
      WINEDLLOVERRIDES: winemenubuilder.exe=d
      WINEPREFIX: $GAMEDIR
    file: $GAMEDIR/MTGA.AppImage
require-binaries: wine
system:
  env:
    WINEARCH: win64
    WINEDEBUG: -all
    WINEDLLOVERRIDES: winemenubuilder.exe=d
    WINEPREFIX: $GAMEDIR

[Kreyren]

Game outputs Wine error if Change payment method in shop is pressed. This doesn't affect gameplay, but it should be investigated.

[Kreyren]

do not merge the patch path is wrong

Update: resolved

[Kreyren]

Some ways wineprefix feature has not been taken fully advantage of.
I still think ntdll is sitll a ntdll.dll.so file.
So with platform stuff.
If it is a PE file things do come different.

Might be alternative solution for ntdll.dll fix instead of using wineappimagebuilder

Relevant: https://www.winehq.org/news/2019070501 (this year feature)

So the older documentation and work around would not have considered that route because it really was not an option.
The old option was basically a Microsoft provide dll or wine internal dll.so we have a third option a wine made pe dll with a patch being used instead of the Microsoft dll
Windows executatable format is PE (Portable Executables)
dll.so that wine has historically used is a elf pe hibrid that could use host platform elf .so files .... This does mean dll.so are not that portable. Also means if a windows applicaiton looked at a dll.so file and sees ELF at the start it can go what in hell I was expecting PE

Also the PE ends in just dll no .so

You have to watch out for anther trap.
Wine generates what is called fake dlls as well.
Inside the wine prefix you can be look at what are fake dlls that are basically enough of a PE file that application looks at it and the applications goes dll exists but when it attempt to use it what is really given is the builtin .dll.so/.dll in the built in directory.
wine is complex little beast with fake dlls, builtin dll and native dll

he built in provide dll will be in like /usr/lib64/wine ie outside the wine prefix with fakes generated in the wineprefix.
native windows libraries/override libraries will be placed in wineprefix than used dlloverride setting to make the built wine dll be ingnored.

kreyren> Are all builtin dlls in /usr/lib64/wine PE libs?
No
some are elf/pe hybrids some are PE these days.

01> being new stuff there is no good documentation on this process either.
<kreyren> > kreytricks_test/wine-4.17/dlls/ntdll/ntdll.dll.so: ELF 64-bit LSB shared object, x86-64, version 1 (SYSV), dynamically linked, BuildID[sha1]=8858036a6746067f0e3f5f93dc56e17da147d43d, not stripped
<kreyren> -> not PE?
<kreyren> or 
<kreyren> > kreytricks_test/wine-4.17/dlls/ntdll/ntdll.dll.fake: PE32+ executable (DLL) x86-64, for MS Windows
<kreyren> this should be patched using provided winehack -> just preloading for WINE should be enough ?
<01> ending in fake I would say that was the fake one built to be placed in the wine directory
<01> I would suspect you have a ntdll.dll.so so that is still a elf/pe hybrid.
<01> kreyren: yes you have a dll.so so that has not been migrated to PE only solution yet.
<01> kreyren: but this is something you need to keep eye on with changed with wine versions as this may or may not change.
<kreyren> might be worth trying though
<kreyren> WINETRICKS_BLACKLIST="45546" LD_PRELOAD="/home/kreyren/kreytricks_test/wine-4.17/dlls/ntdll/ntdll.dll.so" kreytricks prefix=mtga mtg_arena
<kreyren> > /bin/sh: error while loading shared libraries: libwine.so.1: cannot open shared object file: No such file or directory

kreyren: I don't know if you will get this but you cannot use preload with wine elf/pe stuff wine has its own loader that stacks on top of the normal loader. So this is stuff that need to be done by WINEDLLOVERRIDES and WINEDLLPATH yes WINEDLLPATH making the first PATH in list have the replacement ntdll.dll.so and next path point to host will work to replace ntdll.dll.so.

Conclusion: investigate

[Kreyren]

In src/winetricks line 18044:

        if ! grep -qF "for (i = 0; i < 2000; i++)" "$wineappimagebuilder_workdir/wine-4.17/dlls/ntdll/thread.c"; then

                                                    ^-- SC2154: wineappimagebuilder_workdir is referenced but not assigned.

Will be assigned once #1348 is merged

[Kreyren]

Game got updated and the workaround is no longer working -> Update required

[Kreyren]

New update requires powershell apparently (#1391)

[Kreyren]

Transfered in Kreytricks#40 since game needs debugging