Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vcrun use w_try_ms_installer & handle status 236 #1942

Merged

Conversation

Gcenx
Copy link
Contributor

@Gcenx Gcenx commented Aug 7, 2022

vcrun verbs should also use w_try_ms_installer as these installers pass these exit codes.

Also added handling status 236, this being used to indicate a newer version of the dlls already exist. Seen this one after installing Origin then attempting to install vcrun2010.

Seen this happen with vcrun2010 after having Origin installed
@Gcenx
Copy link
Contributor Author

Gcenx commented Aug 7, 2022

Strangely only the x86 installer give this status where x64 didn’t.

@austin987 austin987 merged commit 682ea68 into Winetricks:master Aug 15, 2022
@Gcenx Gcenx deleted the vcrun-use-w_try_ms_installer branch August 15, 2022 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants