New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added new verbs: powershell_core and powershell #2211
Open
ProjectSynchro
wants to merge
10
commits into
Winetricks:master
Choose a base branch
from
ProjectSynchro:master
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Powershell Core is the Latest LTS release that supports both 32 and 64 bit Windows Powershell wrapper code is hosted at: https://github.com/ProjectSynchro/powershell-wrapper-for-wine
Fixes the workaround that gets Star Citizen's RSI Launcher as well as other electron apps using `sudo-prompt` working.
austin987
requested changes
Apr 27, 2024
I tried to derive as much as possible from the metadata (including version from file1), let me know if you'd like any more changes. |
Seems like W_PROGRAMS_UNIX points to the x86 program files directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saw an older PR that died a few years ago so I figured I'd try.
The Powershell Core verb is based on the Latest LTS release that supports both 32 and 64 bit Windows.
I didn't include dotnet48 as it isn't explicitly required by PowerShell Core and is quite heavy to install, it doesn't provide everything you would be using it for anyways. If it's wanted it can trivially be added.
The powershell verb is based on wrapper code is hosted at: https://github.com/ProjectSynchro/powershell-wrapper-for-wine, this is a fork of https://github.com/PietJankbal/powershell-wrapper-for-wine, I contacted the maintainer but they didn't get back to me so I went ahead and forked, if things change the links to the powershell wrapper binaries and profile.ps1 can be changed.
Let me know if there is anything I should do formatting-wise, I kind of copied what was around and attempted to keep things in alphabetical order. I would stick
powershell_core
afterpowershell
, but withpowershell
requiringpowershell_core
it is what it is.