msxml3: added downloading dll with resources for 64-bit #2231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austin987
reviewed
Jun 6, 2024
src/winetricks
Outdated
| @@ -12002,7 +12002,9 @@ load_msxml3() | |||
|
|
|||
| if [ "${W_ARCH}" = "win64" ]; then | |||
| helper_win7sp1_x64 amd64_microsoft-windows-msxml30_31bf3856ad364e35_6.1.7601.17514_none_e6944609ad75ac7d/msxml3.dll | |||
| w_download https://cloudflare-ipfs.com/ipfs/QmanVf9v1NDfBRieGmuHLNkZyoxndijitbTJxs9MyGVpCc?filename=msxml3r.dll 3efa5c3a8ee14c2de9f9ea5507a9950a0d991184dd723c79aca786e0b5fd7cf5 msxml3r.dll | |||
There was a problem hiding this comment.
This doesn't seem like a reputable source (and also makes the verb out of sync with the 32-bit version).
There was a problem hiding this comment.
I moved the dll download so that the 64-bit installation would be more sync with the 32-bit one. Added a comment with information about what is being downloaded.
There was a problem hiding this comment.
That doesn't address the core issue. Taking a dll from windows and putting it on the internet violates Microsoft's copyright. We need a publicly redistributable binary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added downloading and copying msxml3r.dll in system32 for 64-bit prefixes.