Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README's Debian install instructions #2233

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

Captain-Barge
Copy link
Contributor

Change

This PR changes the README's Debian install instructions. It removes the existing link to the unstable Debian package, and replaces it with a link where user the user can first choose their Debian version. This change helps prevent typical users from borking their systems (see below).

Justification

The README.md's Debian install instructions link to winetricks within Debian's sid (unstable) package list. This is fine if someone downloads the winetricks .deb and installs manually, but at the download page the Debian site actually advises against this:

If you are running Debian, it is strongly suggested to use a package manager like aptitude or synaptic to download and install packages, instead of doing so manually via this website.

You should be able to use any of the listed mirrors by adding a line to your /etc/apt/sources.list like this:

deb http://ftp.de.debian.org/debian sid main contrib

Following those instructions is a very bad idea for most users as it creates a difficult-to-unwind "FrankenDebian" situation for those running stable Debian (which is most users). It's not clear to those who might land on that page from the winetricks README.md link that the instructions pertain only to unstable Debian. The change in this PR sends the user to a page where they must choose their appropriate version of Debian.

@austin987
Copy link
Contributor

Change seems fine, but that link is giving me a 503 (and regular search returns no results). I'll try again later.

@austin987 austin987 merged commit 8ffdb53 into Winetricks:master Jun 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants