Fix new Delete with body missing from IWireMockAdminApi interface

[NoahLerner]

As requested.

[StefH]

You need to add the code changes in that 1 file from PR #409 because this was also reverted.

[NoahLerner]

I didn't realize that was reverted too. I resubmitted the code.

[StefH]

This change does not work correctly, because the body is not parsed in this line:

WireMock.Net/src/WireMock.Net/Owin/Mappers/OwinRequestMapper.cs

Line 50 in 3250604

if (request.Body != null && BodyParser.ShouldParseBody(method, options.AllowBodyForAllHttpMethods == true))

(DELETE has no body semantics, so this line will not parse body)

So maybe skip this PR or change it so that your just provide all GUID's in the query string?

[NoahLerner]

This change does not work correctly, because the body is not parsed in this line:

WireMock.Net/src/WireMock.Net/Owin/Mappers/OwinRequestMapper.cs

Line 50 in 3250604

if (request.Body != null && BodyParser.ShouldParseBody(method, options.AllowBodyForAllHttpMethods == true))

(DELETE has no body semantics, so this line will not parse body)
So maybe skip this PR or change it so that your just provide all GUID's in the query string?

I'm not sure what you mean by not working correctly? I tested it and it works fine... as long as AllowBodyForAllHttpMethods is set to true then the body arrives just fine along with the request to private ResponseMessage MappingsDelete(RequestMessage requestMessage).

Also, before opening this PR I looked into whether DELETE can have body semantics and found this documentation saying it may have a body.

Am I missing something?

[NoahLerner]

And also in the RFC, it is not forbidden. It only says that sending a payload body on a DELETE request might cause some existing implementations to reject the request.. But we know this not to be the case in the WireMock.Net implementation...

[StefH]

Currently, the logic form WireMock is that DELETE cannot have a body:

WireMock.Net/src/WireMock.Net/Util/BodyParser.cs

Line 19 in 3250604

/*

Because of this logic, all requests (normal + admin) will not allow a body for delete. This behaviour can indeed be changed by AllowBodyForAllHttpMethods, however this settings is actually meant for normal requests, for admin requests, this should actually not be applied (for admin requests: all is allowed)
This difference in logic is not yet implemented, the OwinRequestMapper.cs maps the request, without knowing if it's a admin request.

So a fix could be:

1. allow body for all delete
2. add special logic to the OwinRequestMapper.cs to determine if it's an admin-request or normal request. Or move the ShouldParseBody check to a later stage. (Maybe MappingMatcher..?)

[NoahLerner]

1. allow body for all delete

Then I think that this should be the fix since the RFC indicates that body is allowed for DELETE.
It also happens to be the simplest fix.
Do you agree?

[StefH]

You also need to update some other unit-tests because of this update.

[NoahLerner]

Yes I see that now. Thanks I'll get to it soon.

[StefH]

please take a look at some comments

[StefH]

see remark about [Theory]

[StefH]

thank you very much