Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not save Mappings when SaveMappingForStatusCodePattern does not match #566

Merged
merged 1 commit into from
Jan 24, 2021

Conversation

StefH
Copy link
Collaborator

@StefH StefH commented Jan 24, 2021

No description provided.

@StefH StefH added the bug label Jan 24, 2021
@StefH StefH self-assigned this Jan 24, 2021
@codecov
Copy link

codecov bot commented Jan 24, 2021

Codecov Report

Merging #566 (41f7136) into master (e8181e9) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #566      +/-   ##
==========================================
+ Coverage   76.51%   76.58%   +0.06%     
==========================================
  Files         145      145              
  Lines        5693     5696       +3     
  Branches      578      579       +1     
==========================================
+ Hits         4356     4362       +6     
+ Misses       1167     1166       -1     
+ Partials      170      168       -2     
Impacted Files Coverage Δ
src/WireMock.Net/Server/WireMockServer.Admin.cs 56.47% <100.00%> (+0.37%) ⬆️
src/WireMock.Net/Proxy/ProxyHelper.cs 89.47% <0.00%> (+1.75%) ⬆️
...rc/WireMock.Net/Settings/ProxyAndRecordSettings.cs 88.88% <0.00%> (+11.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8181e9...41f7136. Read the comment docs.

@StefH
Copy link
Collaborator Author

StefH commented Jan 24, 2021

#565

@sonarcloud
Copy link

sonarcloud bot commented Jan 24, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@StefH StefH merged commit c41989c into master Jan 24, 2021
@StefH StefH deleted the Mapping_NullReferenceException branch January 24, 2021 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant