-
-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prebuild for Node on macOS+arm64 and Windows+ia32 #1002
Conversation
I was copying your code for a different repo (tree-sitter/node-tree-sitter#128) and noticed that you don't do this. |
ac2ffff
to
f44ee25
Compare
+1 |
@mceachen Can this get reviewed? Mac arm builds are no longer being pre-built for regular darwin (only electron darwin). |
+1 I think this would fix #1027 as well. |
Let's get this merged! This doesn't add any code, just compile flags. Should be an easy job! |
This would be so great to get working! |
Would be amazing if this got reviewed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
(Sorry I missed this PR, thanks!) |
Did this PR get reverted? I'm seeing recompiles happen on |
What Node version are you using? It didn't get reverted. The correct files for macOS arm64 are there on the GitHub Release although the release CI failed to run |
I am running I notice there are node binaries for node |
Node 18.7.1 is NODE_MODULE_VERSION 108 |
No description provided.