Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new covenant /api/listeners/bridge api #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TheKevinWang
Copy link

The "/listener/createbridge" api endpoint has been replaced with "/api/listeners/bridge" in cobbr/Covenant@2596571

@shutingrz
Copy link

Oh! I ran into the same problem and made a similar fix.
One thing I would add is that even with this fix, I was not able to run AddPeripheralGrunt.

"GeneratePayload" uses the base64ILByteString returned by the Covenant API.

In the current Covenant, Base64ILByteString is no longer included in the json response.

  • Covenant/Models/Launchers/Launcher.cs
[NotMapped, JsonIgnore, System.Text.Json.Serialization.JsonIgnore]
        public string Base64ILByteString
        {
            get
            {
                try
                {
                    return Convert.ToBase64String(System.IO.File.ReadAllBytes(Common.CovenantLauncherDirectory + Name));
                }
                catch
                {
                    return "";
                }
            }
            set
            {
                System.IO.File.WriteAllBytes(Common.CovenantLauncherDirectory + Name, Convert.FromBase64String(value)); 
            }
        }

Therefore, in order to run AddPeripheralGrunt, I had to remove the JsonIgnore description.

[NotMapped, JsonIgnore, System.Text.Json.Serialization.JsonIgnore]

[NotMapped]

@smntx
Copy link

smntx commented Mar 2, 2021

Cobbr will probably roll out a new api for that - so keep your eyes open for the changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants