Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solution for issue #82 #83

Merged
merged 2 commits into from
Mar 7, 2020
Merged

Solution for issue #82 #83

merged 2 commits into from
Mar 7, 2020

Conversation

gpaulissen
Copy link
Contributor

  • The parsing fo tag 61 for ASN bank is improved.
  • A pytest message concerning peop8 has been suppressed
  • pytest works on my machine for conda python 3.8.1.

@coveralls
Copy link

Coverage Status

Coverage remained the same at ?% when pulling 16ea702 on gpaulissen:feature/asnb-tag-61 into 280f422 on WoLpH:develop.

@wolph wolph merged commit 16ea702 into wolph:develop Mar 7, 2020
@wolph
Copy link
Owner

wolph commented Mar 7, 2020

Thank you for the excellent pull request :)

I've modified the tests slightly so they function for Python versions other than 3.8 as well but beyond that, great work!

@wolph wolph mentioned this pull request Mar 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gpaulissen @coveralls @wolph