Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not install a global 'tests' package #10

Merged
merged 1 commit into from
Jan 15, 2021

Conversation

mgorny
Copy link
Contributor

@mgorny mgorny commented Jan 15, 2021

setuptools.find_packages() finds all valid packages by default that
incidentally includes the test directory that gets installed as global
'tests'. Add an explicit exclude to avoid that.

setuptools.find_packages() finds all valid packages by default that
incidentally includes the test directory that gets installed as global
'tests'.  Add an explicit exclude to avoid that.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling d433290 on mgorny:setup.py-tests into f65dd4b on WoLpH:develop.

@codecov
Copy link

codecov bot commented Jan 15, 2021

Codecov Report

Merging #10 (d433290) into develop (f65dd4b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop       #10   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          202       202           
  Branches        45        45           
=========================================
  Hits           202       202           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f65dd4b...d433290. Read the comment docs.

@wolph
Copy link
Owner

wolph commented Jan 15, 2021

Thank you for the fix :)
I've got similar fixes for many of my other packages but I forgot to do the same for this one.

@wolph wolph merged commit 4b9a75e into wolph:develop Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants