Enduring Luminescence #2361

rp4rk · 2018-10-02T21:50:45Z

Implements the Enduring Luminescence trait for Discipline Priests.

…luminescence merge

joshinat0r

Just some nitpicking on the formatting, the code itself looks good.

joshinat0r · 2018-10-06T08:19:30Z

src/parser/priest/discipline/modules/azeritetraits/EnduringLuminescence.js

+
+  handlePWRBonus(event) {
+    const spellId = event.ability.guid;
+    if (spellId !== SPELLS.POWER_WORD_RADIANCE.id) return;


if () { return; }

just to keep it consistent across the code-base. I personally prefer it this way aswell, but 🤷‍♂️

joshinat0r · 2018-10-06T08:21:16Z

src/parser/priest/discipline/modules/azeritetraits/EnduringLuminescence.js

+    super(...args);
+
+    this.ranks =
+      this.selectedCombatant.traitRanks(SPELLS.ENDURING_LUMINESCENCE.id) || [];


I think Zero had a few weeks ago an argument about max-line length stuff and making too much use of the enter-key.
This should be one line

Yeah sure, thanks for the feedback on formatting. Personally I use prettier with an 80 char max length for diffing side by side, but it's not a huge deal.

joshinat0r · 2018-10-06T08:24:24Z

src/parser/priest/discipline/modules/azeritetraits/EnduringLuminescence.js

+      this.selectedCombatant.traitRanks(SPELLS.ENDURING_LUMINESCENCE.id) || [];
+    this.bonusHealing =
+      this.ranks
+        .map(rank =>


Same as above, I think we usually format it this way.

this.bonusHealing = this.ranks .map(rank => calculateAzeriteEffects(SPELLS.ENDURING_LUMINESCENCE.id, rank)) .reduce((total, bonus) => total + bonus, 0) * HEALING_MULTIPLIER;

joshinat0r · 2018-10-06T08:25:11Z

src/parser/priest/discipline/modules/azeritetraits/EnduringLuminescence.js

+    const target = this.atonement.currentAtonementTargets.find(
+      id => id.target === event.targetID
+    );
+    if (!target) return;


joshinat0r · 2018-10-06T08:25:16Z

src/parser/priest/discipline/modules/azeritetraits/EnduringLuminescence.js

+      id => id.target === event.targetID
+    );
+    if (!target) return;
+    if (!target.isEnduringEmpowered) return;


joshinat0r · 2018-10-06T08:25:51Z

src/parser/priest/discipline/modules/azeritetraits/EnduringLuminescence.js

+      event.timestamp <
+      target.atonementExpirationTimestamp - EnduringLuminescence.bonusDuration
+    )
+      {return;}


if ( event.timestamp < target.atonementExpirationTimestamp - EnduringLuminescence.bonusDuration ) { return; }

joshinat0r · 2018-10-06T08:27:05Z

src/parser/priest/discipline/modules/azeritetraits/EnduringLuminescence.js

+        category={STATISTIC_CATEGORY.AZERITE_POWERS}
+        position={STATISTIC_ORDER.OPTIONAL()}
+        icon={
+          (


The (-bracket isn't necessary and the spellIcon should be in the same line as the icon-prop

This breaks our linting unfortunately, I'll meet at the middle.

TravisBuddy · 2018-10-08T08:54:39Z

Travis tests have failed

Hey @rp4rk,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

Node.js: 10.4

View build log

echo "> The server has already been built so we no longer need the devDependencies (reduces the final bundle size)"

> The server has already been built so we no longer need the devDependencies (reduces the final bundle size)

if [ "$TRAVIS_PULL_REQUEST" != "false" ]; then echo "> Disabling sourcemap generation to save build time, this is a PR so won't be deployed anyway."; export GENERATE_SOURCEMAP=false; fi

> Disabling sourcemap generation to save build time, this is a PR so won't be deployed anyway.

npm run build

> wowanalyzer@ build /home/travis/build/WoWAnalyzer/WoWAnalyzer
> react-scripts build

Creating an optimized production build...
Failed to compile.

./src/parser/priest/discipline/modules/azeritetraits/EnduringLuminescence.js
Cannot find module: 'parser/core/modules/StatTracker'. Make sure this package is installed.

You can install this package by running: npm install parser/core/modules/StatTracker.


npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! wowanalyzer@ build: `react-scripts build`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the wowanalyzer@ build script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/travis/.npm/_logs/2018-10-08T08_54_01_785Z-debug.log

TravisBuddy Request Identifier: c85eb730-cad7-11e8-8b3f-99c2825e6a65

joshinat0r · 2018-10-08T09:12:21Z

Travis failed because the StatTracker is now located in src/parser/shared/modules/StatTracker

Gebuz · 2018-10-08T09:12:37Z

src/parser/priest/discipline/modules/azeritetraits/EnduringLuminescence.js

+      return;
+    }
+
+    let eventHealing = this.bonusHealing;


In general traits are affected by secondary stats and multipliers (except primary stat).

joshinat0r

StatTracker location

TravisBuddy · 2018-11-12T22:52:52Z

Travis tests have failed

Hey @rp4rk,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

View build log

docker build -f .docker/production/Dockerfile --tag wowanalyzer .

Step 1/24 : FROM node:10.12-alpine as app
10.12-alpine: Pulling from library/node



Digest: sha256:1e3e3e7ffc965511c5d4f4e90ec5d9cabee95b5b1fbcd49eb6a2289f425cf183
Status: Downloaded newer image for node:10.12-alpine
 ---> 7ca2f9cb5536
Step 2/24 : WORKDIR /usr/src/app/
 ---> 3f6d1ecd5d57
Removing intermediate container 16fe7f4dfbdd
Step 3/24 : COPY package.json package-lock.json /usr/src/app/
 ---> 1e5efc284185
Step 4/24 : RUN npm install
 ---> Running in 4f4d3ec5e6f0
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@1.2.4 (node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@1.2.4: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

added 1898 packages from 878 contributors and audited 62015 packages in 33.903s
found 0 vulnerabilities

 ---> 65834dd7e610
Removing intermediate container 4f4d3ec5e6f0
Step 5/24 : COPY . /usr/src/app/
 ---> 5ee7c724382e
Step 6/24 : RUN npm run build
 ---> Running in f8e1affd1aaf

> wowanalyzer@ build /usr/src/app
> react-scripts build

Creating an optimized production build...
Failed to compile.

./src/parser/priest/discipline/modules/azeritetraits/EnduringLuminescence.js
Cannot find module: 'parser/core/modules/StatTracker'. Make sure this package is installed.

You can install this package by running: npm install parser/core/modules/StatTracker.


npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! wowanalyzer@ build: `react-scripts build`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the wowanalyzer@ build script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /root/.npm/_logs/2018-11-12T22_52_48_224Z-debug.log
The command '/bin/sh -c npm run build' returned a non-zero code: 1

TravisBuddy Request Identifier: addf0b00-e6cd-11e8-87c2-ebfa2f2e9d99

Dambroda · 2018-11-19T19:27:26Z

No update in a month, and I see some other things that will need changing. Just re-open the PR if you are active and I will put in my review :)

Enduring Luminescence

6b719f5

rp4rk requested review from anom0ly, MartijnHols and karlpralow October 2, 2018 21:50

Merge remote-tracking branch 'upstream/master' into feature/enduring-…

5a4b015

…luminescence merge

joshinat0r requested changes Oct 6, 2018

View reviewed changes

Formatting changes

177d1ca

joshinat0r approved these changes Oct 8, 2018

View reviewed changes

joshinat0r closed this Oct 8, 2018

joshinat0r reopened this Oct 8, 2018

Gebuz reviewed Oct 8, 2018

View reviewed changes

joshinat0r requested changes Oct 8, 2018

View reviewed changes

Merge branch 'master' into feature/enduring-luminescence

8b0834a

Dambroda closed this Nov 19, 2018

rp4rk deleted the feature/enduring-luminescence branch October 18, 2020 03:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enduring Luminescence #2361

Enduring Luminescence #2361

rp4rk commented Oct 2, 2018

joshinat0r left a comment

joshinat0r Oct 6, 2018

joshinat0r Oct 6, 2018

rp4rk Oct 7, 2018

joshinat0r Oct 6, 2018

joshinat0r Oct 6, 2018

joshinat0r Oct 6, 2018

joshinat0r Oct 6, 2018

joshinat0r Oct 6, 2018

rp4rk Oct 7, 2018

TravisBuddy commented Oct 8, 2018

joshinat0r commented Oct 8, 2018

Gebuz Oct 8, 2018

joshinat0r left a comment

TravisBuddy commented Nov 12, 2018

Dambroda commented Nov 19, 2018

Enduring Luminescence #2361

Enduring Luminescence #2361

Conversation

rp4rk commented Oct 2, 2018

joshinat0r left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TravisBuddy commented Oct 8, 2018

Travis tests have failed

Node.js: 10.4

TravisBuddy Request Identifier: c85eb730-cad7-11e8-8b3f-99c2825e6a65

joshinat0r commented Oct 8, 2018

Choose a reason for hiding this comment

joshinat0r left a comment

Choose a reason for hiding this comment

TravisBuddy commented Nov 12, 2018

Travis tests have failed

1st Build

TravisBuddy Request Identifier: addf0b00-e6cd-11e8-87c2-ebfa2f2e9d99

Dambroda commented Nov 19, 2018