np2: experimental feature-complete SSG-EG #81
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is full SSG-EG including support: ALT/ATT/HOLD
I took Nuked OPN2 as basis for comparison.
I plotted the different envelopes and fixed until it matches approximately.
(16 different tests: 8 ssg modes × 2 test situations)
There was 2 cases:
In this special case, "alternate" mode toggles "inversion" bit at every cycle of attack. As such, it seems difficult to determine the final polarity with certainty, other than compute with cycle accuracy.
I made a guess matching with a test instrument, and implemented for the case AR≠$1f. It's probably wrong in cases. As a general rule, SSG-EG attack is best set to zero time.
"Alternance" flag will produce an initial glitch when there is attack time. I did not replicate this in NP2.