Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP #1

Closed
wants to merge 24 commits into from
Closed

WIP #1

wants to merge 24 commits into from

Conversation

Wolfe1
Copy link
Owner

@Wolfe1 Wolfe1 commented Oct 20, 2021

No description provided.

@sourcery-ai sourcery-ai bot mentioned this pull request Oct 20, 2021
@sourcery-ai sourcery-ai bot mentioned this pull request Oct 20, 2021
@sourcery-ai
Copy link

sourcery-ai bot commented Oct 22, 2021

Sourcery Code Quality Report

Merging this PR leaves code quality unchanged.

Quality metrics Before After Change
Complexity 5.42 ⭐ 5.42 ⭐ 0.00
Method Length 41.91 ⭐ 42.02 ⭐ 0.11 👎
Working memory 7.36 🙂 7.35 🙂 -0.01 👍
Quality 75.97% 75.97% 0.00%
Other metrics Before After Change
Lines 3609 3615 6
Changed files Quality Before Quality After Quality Change
src/robot/libraries/BuiltIn.py 75.97% ⭐ 75.97% ⭐ 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
src/robot/libraries/BuiltIn.py _RunKeyword.wait_until_keyword_succeeds 22 😞 185 😞 15 😞 32.45% 😞 Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
src/robot/libraries/BuiltIn.py _Verify.should_contain_any 20 😞 228 ⛔ 13 😞 33.40% 😞 Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
src/robot/libraries/BuiltIn.py _Verify.should_not_contain_any 20 😞 227 ⛔ 13 😞 33.46% 😞 Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
src/robot/libraries/BuiltIn.py _Verify.should_contain_x_times 24 😞 168 😞 13 😞 35.35% 😞 Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
src/robot/libraries/BuiltIn.py _Verify.should_not_contain 19 😞 154 😞 13 😞 40.12% 😞 Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@Wolfe1 Wolfe1 closed this Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant