Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added columns using Professor_Kukui's method for ranking movesets #213

Merged
merged 3 commits into from
Aug 12, 2016

Conversation

607ch00
Copy link
Contributor

@607ch00 607ch00 commented Aug 12, 2016

@Wolfsblvt Wolfsblvt added this to the v0.1.2-Beta milestone Aug 12, 2016
@Wolfsblvt
Copy link
Owner

Wolfsblvt commented Aug 12, 2016

Oki doki loki.
This looks good. Guess @QuadTog has to take a look over it later.

And you should maybe refactor the Utils more with primitive tyed instead of boxing.
Btw, is there a reason why two columns are long and the third is not? Just make all three longs. As if it that would be a problem. It's just more consistent.

You can work on those things later, from the latest develop version. I will merge now. It works fine, it's just some more refactoring that can be done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants