-
Notifications
You must be signed in to change notification settings - Fork 10
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Kotlin migration fixes - update versions (#59)
* Fixing overriding base presenter * Presenter as val * Fix tests * Get presnter instead of require * Fixing wolmo fragment inject * DefaultModule as class * Shared preferences string nullable * Android core as api * Reverting modules * Updating version * Updating versions * Fixing tests * Using implmentation * API insteda of implementation revert
- Loading branch information
1 parent
8558258
commit 000fad9
Showing
19 changed files
with
173 additions
and
191 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
63 changes: 63 additions & 0 deletions
63
core/src/main/java/ar/com/wolox/wolmo/core/di/modules/DefaultModule.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,63 @@ | ||
/* | ||
* Copyright (c) Wolox S.A | ||
* | ||
* Permission is hereby granted, free of charge, to any person obtaining a copy | ||
* of this software and associated documentation files (the "Software"), to deal | ||
* in the Software without restriction, including without limitation the rights | ||
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
* copies of the Software, and to permit persons to whom the Software is | ||
* furnished to do so, subject to the following conditions: | ||
* | ||
* The above copyright notice and this permission notice shall be included in | ||
* all copies or substantial portions of the Software. | ||
* | ||
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | ||
* THE SOFTWARE. | ||
*/ | ||
package ar.com.wolox.wolmo.core.di.modules; | ||
|
||
import android.util.SparseArray; | ||
|
||
import ar.com.wolox.wolmo.core.fragment.WolmoFragmentHandler; | ||
import ar.com.wolox.wolmo.core.permission.PermissionListener; | ||
import ar.com.wolox.wolmo.core.presenter.BasePresenter; | ||
import ar.com.wolox.wolmo.core.util.Logger; | ||
import ar.com.wolox.wolmo.core.util.ToastFactory; | ||
|
||
import dagger.Component; | ||
import dagger.Module; | ||
import dagger.Provides; | ||
|
||
/** | ||
* Provides default implementations for Wolmo's dependencies and utils. | ||
* You can add this module to your {@link Component} if you don't need to customize any dependency. | ||
*/ | ||
@Module | ||
public class DefaultModule { | ||
|
||
@Provides | ||
static SparseArray<PermissionListener> providesPermissionManagerArray() { | ||
return new SparseArray<>(); | ||
} | ||
|
||
@Provides | ||
static BasePresenter providesDefaultBasePresenter() { | ||
return new BasePresenter(); | ||
} | ||
|
||
/** | ||
* Provides a default {@link WolmoFragmentHandler} with no presenter for fragments that don't | ||
* need it. | ||
*/ | ||
@Provides | ||
static WolmoFragmentHandler providesDefaultWolmoFragmentHandler(ToastFactory toastFactory, | ||
Logger logger, | ||
BasePresenter<Object> basePresenter) { | ||
return new WolmoFragmentHandler<>(toastFactory, logger, basePresenter); | ||
} | ||
} |
57 changes: 0 additions & 57 deletions
57
core/src/main/java/ar/com/wolox/wolmo/core/di/modules/DefaultModule.kt
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.