Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Password visibility toggle does not correctly handle hidden password fields #4040

Closed
TimWolla opened this issue Mar 1, 2021 · 2 comments · Fixed by #4167
Closed

Password visibility toggle does not correctly handle hidden password fields #4040

TimWolla opened this issue Mar 1, 2021 · 2 comments · Fixed by #4167
Assignees
@TimWolla
Labels
Bug
Projects
WoltLab Suite 5.4

Comments

@TimWolla
Copy link
Member

TimWolla commented Mar 1, 2021 •
edited

e.g. fakepasswordremembered within the settings.
Bildschirmfoto von 2021-03-01 11-24-41
@TimWolla TimWolla added the Bug label Mar 1, 2021
@TimWolla TimWolla added this to Needs Triage in WoltLab Suite 5.4 via automation Mar 1, 2021
@TimWolla TimWolla moved this from Needs Triage to Available in WoltLab Suite 5.4 Mar 1, 2021
@TimWolla
Copy link
Member Author

A possible solution might be using the hidden attribute instead of display: none and then:

[hidden] + .inputSuffix { display: none; }

@TimWolla
Copy link
Member Author

There's also quite a few updates to the Stack Overflow answer where these fields have been taken from: https://stackoverflow.com/a/15917221/782822. Maybe it should be rechecked whether these fields are still the best solution.

TimWolla added a commit that referenced this issue Apr 30, 2021
@TimWolla
Fix the password toggle from showing up for the fake input in option.tpl
2cef6eb 
Fixes #4040
@TimWolla TimWolla mentioned this issue Apr 30, 2021
Merged
@TimWolla TimWolla self-assigned this Apr 30, 2021
@TimWolla TimWolla moved this from Available to In Progress in WoltLab Suite 5.4 Apr 30, 2021
WoltLab Suite 5.4 automation moved this from In Progress to Resolved Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TimWolla TimWolla

Labels
Bug
Projects
No open projects
WoltLab Suite 5.4
  
Resolved
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix the password toggle from showing up for the fake input in option.tpl WoltLab/WCF
1 participant
@TimWolla