Upgrade leafo/scssphp to scssphp/scssphp #3415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The basic usage of this compatibility layer appears to work well: A CSS file can be compiled from the default style, without needing any additional adjustments. What this compatibility layer cannot do is rewrite the Exceptions that are thrown by scssphp/scssphp. A strict catch block catching a specific Exception, such as `\Leafo\ScssPhp\Exception\ParserException` will not match the aliased `ScssPhp\ScssPhp\Exception\ParserException`. Resolves #3398
dtdesign
approved these changes
Jul 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quoting from the second commit message:
Resolves #3398