Overhaul of the user panel menu #4603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Favico.js was used exclusively for the notification badge in the favicon, but was replaced with a lightweight implementation. The user panel items cannot be properly mapped to the new implementations, if a custom version of `pageHeaderUser.tpl` is being used, then they are screwed anyway.
``` cp node_modules/tabbable/dist/index.umd.min.js wcfsetup/install/files/js/3rdParty/focus-trap/ cp node_modules/tabbable/dist/index.umd.min.js.map wcfsetup/install/files/js/3rdParty/focus-trap/ ``` ``` cp node_modules/focus-trap/dist/focus-trap.umd.min.js wcfsetup/install/files/js/3rdParty/focus-trap/ cp node_modules/focus-trap/dist/focus-trap.umd.min.js.map wcfsetup/install/files/js/3rdParty/focus-trap/ ```
It doesn't play nicely with the UI/UX concept
TimWolla
reviewed
Dec 8, 2021
wcfsetup/install/files/lib/data/moderation/queue/ModerationQueueAction.class.php
Outdated
Show resolved
Hide resolved
wcfsetup/install/files/lib/data/user/notification/UserNotificationAction.class.php
Outdated
Show resolved
Hide resolved
|
The commit c9e8db8 might not be immediately obvious, but this is pretty much what the previous implementation does by slapping |
TimWolla
approved these changes
Dec 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The menu has been rebuilt from the ground up with simplicity, consistent styling and a11y in mind. It introduces a set of new style variables to avoid the pitfall of deriving colors from different elements just because the happen to fit in nicely in the default style.
This change is the first step towards the new mobile menu which will be built on top of this. For now the conversation menu has been left unchanged to serve as a blueprint for the backwards compatibility layer.