Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework Poll JS to TypeScript #4662

Merged
merged 19 commits into from Feb 28, 2022
Merged

Rework Poll JS to TypeScript #4662

merged 19 commits into from Feb 28, 2022

Conversation

joshuaruesweg
Copy link
Member

No description provided.

@joshuaruesweg joshuaruesweg added this to Needs Triage in WoltLab Suite 5.5 via automation Feb 7, 2022
TimWolla
TimWolla reviewed Feb 7, 2022
View reviewed changes
Copy link
Member

@TimWolla TimWolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't comment to the overall changes, just some remarks regarding localized changes.

ts/WoltLabSuite/Core/Ui/Poll/Manager/Vote.ts Outdated Show resolved Hide resolved
ts/WoltLabSuite/Core/Ui/Poll/Manager/Vote.ts Outdated Show resolved Hide resolved
dtdesign
dtdesign requested changes Feb 8, 2022
View reviewed changes
com.woltlab.wcf/templates/poll.tpl Show resolved Hide resolved
com.woltlab.wcf/templates/poll.tpl Outdated Show resolved Hide resolved
ts/WoltLabSuite/Core/Ui/Poll/Manager/Manager.ts Outdated Show resolved Hide resolved
ts/WoltLabSuite/Core/Ui/Poll/Manager/Manager.ts Outdated Show resolved Hide resolved
ts/WoltLabSuite/Core/Ui/Poll/Manager/Manager.ts Outdated Show resolved Hide resolved
ts/WoltLabSuite/Core/Ui/Poll/Manager/View/Abstract.ts Outdated Show resolved Hide resolved
ts/WoltLabSuite/Core/Ui/Poll/Manager/View/Participants.ts Outdated Show resolved Hide resolved
ts/WoltLabSuite/Core/Ui/Poll/Manager/Vote.ts Outdated Show resolved Hide resolved
ts/WoltLabSuite/Core/Ui/Poll/Manager/Vote.ts Outdated Show resolved Hide resolved
ts/WoltLabSuite/Core/Ui/Poll/Manager/Vote.ts Outdated Show resolved Hide resolved
@TimWolla TimWolla moved this from Needs Triage to In Progress in WoltLab Suite 5.5 Feb 22, 2022
dtdesign
dtdesign requested changes Feb 22, 2022
View reviewed changes
ts/WoltLabSuite/Core/Ui/Poll/Manager/Poll.ts Outdated Show resolved Hide resolved
ts/WoltLabSuite/Core/Ui/Poll/Manager/Poll.ts Outdated Show resolved Hide resolved
ts/WoltLabSuite/Core/Ui/Poll/Manager/Poll.ts Outdated Show resolved Hide resolved
ts/WoltLabSuite/Core/Ui/Poll/Manager/Poll.ts Outdated Show resolved Hide resolved
ts/WoltLabSuite/Core/Ui/Poll/Manager/Poll.ts Outdated Show resolved Hide resolved
ts/WoltLabSuite/Core/Ui/Poll/Manager/Poll.ts Outdated Show resolved Hide resolved
ts/WoltLabSuite/Core/Ui/Poll/Manager/View/Results.ts Outdated Show resolved Hide resolved
ts/WoltLabSuite/Core/Ui/Poll/Manager/View/Vote.ts Outdated Show resolved Hide resolved
ts/WoltLabSuite/Core/Ui/Poll/Manager/Vote.ts Outdated Show resolved Hide resolved
dtdesign
dtdesign reviewed Feb 28, 2022
View reviewed changes
Copy link
Member

@dtdesign dtdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshuaruesweg joshuaruesweg merged commit ae2cca0 into master Feb 28, 2022
@joshuaruesweg joshuaruesweg deleted the 5.5-poll-js branch February 28, 2022 13:43
WoltLab Suite 5.5 automation moved this from In Progress to Resolved Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtdesign dtdesign dtdesign requested changes

@TimWolla TimWolla TimWolla left review comments

Assignees
No one assigned
Labels
Feature
Projects
No open projects
WoltLab Suite 5.5
  
Resolved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@joshuaruesweg @dtdesign @TimWolla