Return Types for ITitledObject::getLink() and ILinkableObject::getLink()

[mutec]

This prevents issues in case one would return null or other types.

[TimWolla]

Can you please further split this into 2 commits each:

1. Apply the return type to the implementing classes, this is valid, because return types are covariant.
2. Apply the return type to the interface itself.

[mutec]

@TimWolla I just splitted the commits. Is there any deep sense behind that separation?

[TimWolla]

Thank you. Can you drop the annotated PHPDoc line and slightly reword the commit messages when you are rebasing anyway? “Return Value Type” misleadingly parses as “Return (Value Type)” instead of “(Value Value) Type” for me.

Let me suggest the following prasing:

• Add proper string return type to implementations of Foo::bar()
• Add proper string return type to Foo::bar()

[TimWolla]

Is there any deep sense behind that separation?

Generally it's considered good commit hygiene to make commits as small and self-contained as possible. In this specific case it's logically two different types of change and by splitting them into different commits, they can be independently reverted if the need arises. If it turns out that the break from the explicit type in the interface is too bad, that one can be reverted without losing the explicit types in the implementing classes.

[TimWolla]

Perfect, thank you. I'll handle updating the return types in the other packages (including the open sourced ones).