Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ImportExportViewModel Refactoring: consolidating Process Selected and Process All paths #1000

Merged
merged 1 commit into from
Nov 9, 2022
Merged

ImportExportViewModel Refactoring: consolidating Process Selected and Process All paths #1000

merged 1 commit into from
Nov 9, 2022

Conversation

kwekmaster
Copy link
Contributor

Title says it all. Referencing methods will not feel any difference.

Implemented:

  • Congruent code paths moved into a new Process Bulk method

Testing Done:

  • Ensure that Process All and Process Selected works just like before from the UI.

rfuzzo
rfuzzo approved these changes Nov 9, 2022
View reviewed changes
Copy link
Member

@rfuzzo rfuzzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rfuzzo rfuzzo merged commit 737798d into WolvenKit:main Nov 9, 2022
@kwekmaster kwekmaster mentioned this pull request Nov 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfuzzo rfuzzo rfuzzo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kwekmaster @rfuzzo