Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore performance--fix a potential slight slowdown introduced by PR#1000 #1003

Merged
merged 1 commit into from
Nov 9, 2022

Conversation

kwekmaster
Copy link
Contributor

My oversight introduced a potential performance difference for Process All in #1000
This may be observed when the user has a lot of files to process. I figured I'd do the right thing while it's still fresh in my brain.

Fixed:

  • Flip the boolean condition check so Process All results in a short-circuit eval, theoretically providing equal performance as before.
  • use the total variable--this approach wasn't introduced in my change, but I feel that we should be consistent. Might as well.

@kwekmaster kwekmaster changed the title Restore performance--fix slight slowdown introduced by PR#1000 Restore performance--fix a potential slight slowdown introduced by PR#1000 Nov 9, 2022
@rfuzzo rfuzzo merged commit 335b8fe into WolvenKit:main Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants