Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃摏 Export/Import Type Tagged .morphtarget GLTF #1196

Merged
merged 6 commits into from
Mar 8, 2023

Conversation

effs
Copy link
Contributor

@effs effs commented Mar 6, 2023

Minimal, unstructured scaffolding to import/export type-tagged GLTFs. Since this is more involved than is ideal, export is just supported for .morphtarget (so that it is distinct from a .mesh export.)

You can, however, use file naming to avoid having to select the import format for GLTFs.

BUT

Rather than try to surgically fix things here and there, I think the best option is to:

  1. Get rid of the separate Mesh, WithRig and Multimesh exports and just treat everything as cases of Multimesh in a single code path (which is what import does on the return trip.) This also needs a better UI, but should work transparently anyway. -> Doing this in 鈾伙笍 Experimental Unified Mesh Exporter聽#1197

  2. Try to separate import/export data handling from the filesystem ops, either by returning data streams from the exporters, or by passing in a fs context that cannot be changed downstream.

  3. Then maybe doing something more.

Copy link
Member

@rfuzzo rfuzzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good (can't comment on the actual mesh logic though).

In the future, it would be great if commits did not contain any emojis please!

@rfuzzo rfuzzo merged commit 290c661 into main Mar 8, 2023
@rfuzzo rfuzzo deleted the feat/import-export-bimsness-gltf-typenames branch March 8, 2023 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants