Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Experimental Unified Mesh Exporter #1197

Merged

Conversation

effs
Copy link
Contributor

@effs effs commented Mar 7, 2023

Trying to get rid of duplication and possible NOT duplication in the mesh/withrig/multi export path. The import already uses one code path.

⚗️ Experimental category + feature toggle for new mesh export logic
✨ Happy path for single mesh export works

  • Actually test the other stuff too (but maybe YOU can do it)
  • Figure out some way to thread a default from Settings to the frontend. App vs. Common, or something -.-

Witness, a toggle:

image

@effs effs changed the base branch from main to feat/import-export-bimsness-gltf-typenames March 7, 2023 15:11
@effs effs changed the title 🚧 WIP Unified Mesh Exporting ♻️ Experimental Unified Mesh Exporter Mar 8, 2023
@effs effs force-pushed the wip/unified-mesh-exports branch from 3ca0871 to bac8bcd Compare March 8, 2023 00:29
@effs effs force-pushed the wip/unified-mesh-exports branch from bac8bcd to 6af29e4 Compare March 8, 2023 00:35
@effs effs marked this pull request as ready for review March 8, 2023 00:38
@rfuzzo rfuzzo merged commit bebc759 into feat/import-export-bimsness-gltf-typenames Mar 8, 2023
@rfuzzo rfuzzo deleted the wip/unified-mesh-exports branch March 8, 2023 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants