Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New User email producing issues. #1215

Closed
Benunc opened this issue Nov 10, 2016 · 1 comment
Closed

New User email producing issues. #1215

Benunc opened this issue Nov 10, 2016 · 1 comment

Comments

@Benunc
Copy link
Member

Benunc commented Nov 10, 2016

Issue Overview

New User email is plaintext, or otherwise broken.

Expected Behavior

It should either send a full html email, or not include html tags.

Current Behavior

When a new user is sent an email, the function here is broken.
https://github.com/WordImpress/Give/blob/master/includes/user-functions.php#L405-L446

specifically the error appears to be in this line:
https://github.com/WordImpress/Give/blob/master/includes/user-functions.php#L434

Here's a user screenshot of this error:
screen-shot

I was able to reproduce locally. Here's a screenshot
screen shot 2016-11-09 at 7 36 05 pm

and here's the source from mailcatcher:

Password: [Password entered during donation]
<a href=3D"https://givepress.dev/wp-login.php"> Click Here to Login &raqu=
o;</a>

Possible Solution

Steps to Reproduce (for bugs)

  1. Ensure that new user registration is required (disable logged out donations)
  2. complete a donation
  3. check the email that is sent

It will be broken.

@DevinWalker DevinWalker added this to the 1.9 milestone Nov 11, 2016
@DevinWalker
Copy link
Member

Close in favor of: #1346

@DevinWalker DevinWalker modified the milestones: 1.9, 2.0 Apr 10, 2017
@DevinWalker DevinWalker removed this from the 2.0 milestone Jan 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants