Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ALL the ids be unique to avoid multiple identical ids when multiple forms are on the page #379

Closed
mathetos opened this issue Oct 30, 2015 · 3 comments
Assignees

Comments

@mathetos
Copy link
Member

Currently because many of the IDs are generic we'll always produce a not-fully-accessible page if there are even just two Give forms on the page at the same time. To avoid that we just need to add the form_id to each and every ID, or remove unnecessary IDs.

@mathetos
Copy link
Member Author

@TheGeniusWM I created a new page on the test site to test this PR:
http://b8d.3e8.myftpupload.com/multiple-donation-forms/

Please run your tool on that and hopefully we pass! I believe this is the last item on the list.

@mathetos
Copy link
Member Author

Just following up that we had a user with this problem again today. He used two forms on the page both of which used the radio buttons. When the bottom forms radio text was clicked it affected the amount in the upper form and scrolled the user up to the upper form.

Relevant HelpScout ticket: https://secure.helpscout.net/conversation/195970553/1817/

@DevinWalker
Copy link
Member

Closing in favor of #325 which this issue is addressed within

@DevinWalker DevinWalker removed this from the 1.5 milestone Jun 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants