Refactored includes/forms/template.php to have unique IDs #380
Conversation
…board. Also cleaned up markup to be more semantic. Required changes to JS files as well, so careful review would be necessary.
|
It's looking really good! I think the one thing that needs to be standardized is the underscore vs hyphen usage within the selectors. I think we should stick with the hypens as I a rarely see underscores used for classes/ids. Sound good? :) |
…res in includes/forms/template.php
|
@DevinWalker The PR is refreshed to make all IDs and Classes consistently use dashes instead of underscores. The "show terms" reveal link was also not working correctly previously, that's corrected in the refreshed PR. |
|
@mathetos I also see you update the name attribute with hyphens which can cause issues with the way donations are processed. Let's discuss this PR together tomorrow. |
| <input class="give-input required" type="text" name="give_first" placeholder="<?php _e( 'First name', 'give' ); ?>" id="give-first" value="<?php echo is_user_logged_in() ? $user_data->first_name : ''; ?>"<?php if ( give_field_is_required( 'give_first', $form_id ) ) { echo ' required '; } ?>/> | ||
| </p> | ||
| <input class="give-input required" type="text" name="give-first" placeholder="<?php _e( 'First name', 'give' ); ?>" id="give-first-<?php echo $form_id; ?>" value="<?php echo is_user_logged_in() ? $user_data->first_name : ''; ?>"<?php if ( give_field_is_required( 'give-first', $form_id ) ) { echo ' required '; } ?>/> | ||
| </div> |
There was a problem hiding this comment.
It's OK for name attributes to use underscores
|
Closing this since it's out of date and incompatible now. |
Fixes #379
Also cleaned up markup to be more semantic. Required changes to JS files as well, so careful review would be necessary.