translate() sniff returns false negative for $obj->translate()

[roborourke]

Bug Description

I'm using the Google Translate API client, you get the client object and that has a translate() method.

The sniff WordPress.WP.I18n.NonSingularStringLiteralDomain catches any usage of translate() stating it's reserved for low level usage.

Minimal Code Snippet

<?php
class Translator {
    function translate() {
       return 'foo';
    }
}
$translator = new Translator();
echo $translator->translate();

Environment

Question	Answer
PHP version	7.2
PHP_CodeSniffer version	2.9.0
WPCS version	0.14.0
WPCS install type	Composer project local

Tested Against develop branch?

• I have verified the issue still exists in the develop branch of WPCS.

[jrfnl]

@roborourke Please upgrade the version of WPCS you are using. The current version is 1.2.0.

Closing as duplicate of #1266 which was fixed in WPCS 1.0.0.

[roborourke]

Apologies, not sure why we’re so far behind on versions :/

…

On Wed, 14 Nov 2018 at 19:23, Juliette ***@***.***> wrote: Closed #1535 <#1535> . — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1535 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABbeTwwE_pCMD0S_LF74GY8zqtS44rkks5uvG2wgaJpZM4YeSzG> .

[jrfnl]

No worries. When you upgrade, please have a read through the changelogs. Especially WPCS 1.0.0 contains some BC-breaks which you probably should be aware of.