Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Learn WordPress Content Error Report - Ticket #1113

Closed
4 tasks
ockham opened this issue Nov 22, 2022 · 5 comments
Closed
4 tasks

Learn WordPress Content Error Report - Ticket #1113

ockham opened this issue Nov 22, 2022 · 5 comments
Labels
Awaiting Triage Issues awaiting triage. See Training Team handbook for how to triage issues. [Content] Feedback Feedback provided about content on Learn.

Comments

@ockham
Copy link

ockham commented Nov 22, 2022

Error Description

There's currently no mention of Style Variations: A block theme's child theme will currently not automatically include the parent's Style Variations. To have them included, the child theme's author will have to copy the parent theme's styles/ directory.

Originally reported in WP.org support forums here. I've filed a Gutenberg issue to change that behavior (i.e. to auto-include the parent's style variations), but for the time being, it'd be good to explain how to include them manually.

Per discussion with @jonathanbossenger, we might want to review the behavior of child themes for other block theme capabilities (e.g. template parts of block patterns) and add instructions (rather than focusing on style variations only).

Error Report Checklist:

  • Error Validated
  • Error fix proposed
  • Error fix reviewed
  • Error fix published
@ockham ockham added [Type] Bug Something isn't working on the Learn website. Awaiting Triage Issues awaiting triage. See Training Team handbook for how to triage issues. Content Error labels Nov 22, 2022
@jonathanbossenger
Copy link
Collaborator

I think a good way forward here is to create additional separate content about block theme capabilities in a child theme

  1. Child theme basics (already covered by https://learn.wordpress.org/lesson-plan/create-a-basic-child-theme-for-block-themes/)
  2. Theme.json in child themes
  3. Templates and template parts in child themes
  4. Patterns in child themes
  5. Styles in child themes

@ockham
Copy link
Author

ockham commented Jan 18, 2023

Update, per WordPress/gutenberg#46554, child themes now inherit their parent theme's style variations. We might close this issue (and potentially file a new one for the items @jonathanbossenger mentioned in #1113 (comment)).

@bsanevans bsanevans added [Content] Feedback Feedback provided about content on Learn. and removed [Type] Bug Something isn't working on the Learn website. labels Feb 9, 2023
@nomad-skateboarding-dev

Error Validated

Error was discussed by @ockham and @jonathanbossenger . Block child themes now inherit parent theme's style variations.

Proposed Fix

Close issue and follow up with @jonathanbossenger recommendations as proposed by @ockham

@bsanevans
Copy link
Contributor

Thank you for the feedback. I'm closing this issue now and will follow up with Jonathan about opening a new issue for his other suggestions.

@bsanevans
Copy link
Contributor

I've submitted the content ideas above here: #1556

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Triage Issues awaiting triage. See Training Team handbook for how to triage issues. [Content] Feedback Feedback provided about content on Learn.
Projects
Development

No branches or pull requests

4 participants