CS: minor nitpicks

* Add missing `@throws` tag. * Remove unused import `use` statements. * Alphabetically ordered import `use` statements. * Blank line before the test assertions.
WordPress · Jan 9, 2024 · 47cda6a · 47cda6a
1 parent aa4d7dd
commit 47cda6a
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 4 deletions.
diff --git a/src/Utility/HttpStatus.php b/src/Utility/HttpStatus.php
@@ -837,6 +837,7 @@ final class HttpStatus {
 	 *
 	 * @param int|string $code Status code.
 	 * @return string Status message.
+	 * @throws \WpOrg\Requests\Exception\InvalidArgument When the passed $code argument is not a valid status code.
 	 */
 	public static function get_text($code) {
 		if (self::is_valid_code($code) === false) {

diff --git a/tests/Exception/Http/StatusCodeTest.php b/tests/Exception/Http/StatusCodeTest.php
@@ -4,8 +4,8 @@
 
 use WpOrg\Requests\Exception\Http;
 use WpOrg\Requests\Response;
-use WpOrg\Requests\Utility\HttpStatus;
 use WpOrg\Requests\Tests\TestCase;
+use WpOrg\Requests\Utility\HttpStatus;
 
 /**
  * @covers \WpOrg\Requests\Exception\Http\Status304
@@ -124,6 +124,7 @@ public function testKnownStatusCodes($status_code, $expected_exception_class) {
 
 		$exception_class  = Http::get_class($status_code);
 		$exception_object = new $exception_class('testing-1-2-3');
+
 		$this->assertInstanceOf(Http::class, $exception_object);
 		$this->assertInstanceOf($expected_exception_class, $exception_object);
 	}

diff --git a/tests/Utility/HttpStatus/GetTextTest.php b/tests/Utility/HttpStatus/GetTextTest.php
@@ -2,7 +2,6 @@
 
 namespace WpOrg\Requests\Tests\Utility\HttpStatus;
 
-use WpOrg\Requests\Exception;
 use WpOrg\Requests\Exception\InvalidArgument;
 use WpOrg\Requests\Tests\TestCase;
 use WpOrg\Requests\Tests\TypeProviderHelper;

diff --git a/tests/Utility/HttpStatus/IsValidCodeTest.php b/tests/Utility/HttpStatus/IsValidCodeTest.php
@@ -2,8 +2,6 @@
 
 namespace WpOrg\Requests\Tests\Utility\HttpStatus;
 
-use WpOrg\Requests\Exception;
-use WpOrg\Requests\Exception\InvalidArgument;
 use WpOrg\Requests\Tests\TestCase;
 use WpOrg\Requests\Tests\TypeProviderHelper;
 use WpOrg\Requests\Utility\HttpStatus;