Drop support for PHP < 5.6 & PEAR #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrfnl
force-pushed
the
feature/460-drop-support-for-php-lt-5.6
branch
from
658929a
to
2c873b1
Compare
jrfnl
force-pushed
the
feature/460-drop-support-for-php-lt-5.6
branch
from
2c873b1
to
9671498
Compare
jrfnl
force-pushed
the
feature/460-drop-support-for-php-lt-5.6
branch
from
9671498
to
73e37ea
Compare
schlessera
approved these changes
Jun 4, 2021
This drops support for PHP < 5.6 by:
* Upping the minimum required PHP version in all the relevant places.
* Dropping CI runs against PHP < 5.6.
This includes removing the Travis script which only still handled PHP 5.2-5.4.
* PHPCS: upping the minimum PHP version and removing exceptions for PHPCompatibility related to PHP < 5.6.
* PHPUnit: don't allow PHPUnit 4.x to be installed anymore.
This does require to `composer install` with `--ignore-platform-reqs` for PHP 8.0+ in the `lint` workflow. Previously, PHPUnit 4.x would be installed as that was the last PHPUnit version which did not have a `require` set for the PHP versions.
* Dropping some obvious code work-arounds which were in place for PHP < 5.6.
This drops support for PEAR by:
* Removing the `package.xml.tpl`
* Removing the PEAR package generation script.
Related to 460
Closes 378
jrfnl
force-pushed
the
feature/460-drop-support-for-php-lt-5.6
branch
from
73e37ea
to
38018fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This drops support for PHP < 5.6 by:
This includes removing the Travis script which only still handled PHP 5.2-5.4.
This does require to
composer installwith--ignore-platform-reqsfor PHP 8.0+ in thelintworkflow (for now). Previously, PHPUnit 4.x would be installed as that was the last PHPUnit version which did not have arequireset for the PHP versions.This drops support for PEAR by:
package.xml.tplRelated to #460
Closes #378