Tests: new Cookie\FormatTest class
#740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... with dedicated tests for the `Cookie::__toString()`, `Cookie::format_for_header()` and the `Cookie::format_for_set_cookie()` methods. Includes removing some test code from the `CookieTest` class which is now covered by the tests in this class. Also take note that, IMO, some of these tests highlight potential bugs. I'd like a second opinion on this though before addressing this.
Should we discuss this here or in a separate issue to unblock and merge this PR ? |
1 task
|
I've opened #743 to discuss the potential bugs. |
|
I've rebased the PR after the recent merges and added one additional test case to the |
schlessera
approved these changes
Jun 20, 2022
jrfnl
added a commit
that referenced
this pull request
Jun 20, 2022
Hmm... looks like I apparently forgot to push the additional test case I mentioned in #740 (comment) .... oops... Let's have it anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... with dedicated tests for the
Cookie::__toString(),Cookie::format_for_header()and theCookie::format_for_set_cookie()methods.Includes removing some test code from the
CookieTestclass which is now covered by the tests in this class.