Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent cURL transport from leaking on Exception #319

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

Prevent cURL transport from leaking on Exception #319

wants to merge 10 commits into from

Commits on Sep 11, 2023

  1. Prevent cURL transport from leaking on Exception 

    The `CURLOPT_HEADERFUNCTION` and `CURLOPT_WRITEFUNCTION` options are not
being reset if a cURL handle error occurs (which throws a
`Requests_Exception` and stops execution). The destructor is not called
due to lingering instance method callbacks in the two options.

Move `CURLOPT_HEADERFUNCTION` and `CURLOPT_WRITEFUNCTION` cleanup before
any exceptions can happen.
    @soulseekah @schlessera
    soulseekah authored and schlessera committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    a039381 View commit details
    Browse the repository at this point in the history

  2. Assert that cURL handles are correctly closed

    @schlessera
    schlessera committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    76be0b7 View commit details
    Browse the repository at this point in the history

  3. Use assertIsClosedResource from PHPUnit polyfills

    @schlessera
    schlessera committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    7a56b5c View commit details
    Browse the repository at this point in the history

  4. Use try-finally clause

    @schlessera
    schlessera committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    846ea8f View commit details
    Browse the repository at this point in the history

  5. Minor tweaks

    @jrfnl @schlessera
    jrfnl authored and schlessera committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    4589dba View commit details
    Browse the repository at this point in the history

  6. Fix cURL handle locking when file stream is broken

    @schlessera
    schlessera committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    e67a478 View commit details
    Browse the repository at this point in the history

  7. Make blocking check more consistent with rest of the code

    @schlessera
    schlessera committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    30afc43 View commit details
    Browse the repository at this point in the history

  8. Fix hooks processing in cURL tests

    @schlessera
    schlessera committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    dd91131 View commit details
    Browse the repository at this point in the history

  9. Use weak references to avoid the test causing a leak

    @schlessera
    schlessera committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    61b3b14 View commit details
    Browse the repository at this point in the history

  10. Bump use of weak references to PHP 7.4

    @schlessera
    schlessera committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    e1cd380 View commit details
    Browse the repository at this point in the history