Declare classes as final whenever possible #534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... and make all `protected` methods within them `private`.
... and make all `protected` methods within them `private` and when the class doesn't extend or implement, the properties too.
schlessera
approved these changes
Sep 17, 2021
jrfnl
added a commit
that referenced
this pull request
Nov 5, 2021
In PR #534 (to address #514), a number of classes were made `final`. This effectively broke the BC-layer for the Composer autoloader as that BC-layer relied on the "old" class names extending the new ones. Fixed now by: * Using the new custom autoloader - which uses class aliasing, which is not affected by the change to `final` - for the BC-layer for Composer. * Automatically loading the file via the composer `autoload` directive. While using the `files` directive in Composer `autoload` is generally a last resort, as this file only registers an autoloader and Composer autoload is used for just that purpose, this should not be a problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
This is a:
Context
Improve maintainability and make the interface of what are breaking changes smaller.
Fixes #514
Detailed Description
Tests: declare base TestCase as abstract
Tests: make all concrete test classes final
... and make all
protectedmethods within themprivate.Exceptions: make all concrete Exception classes final
Src: make select concrete classes final
... and make all
protectedmethods within themprivateand when the class doesn't extend or implement, the properties too.Quality assurance
Documentation
For new features:
examplesdirectory.docsdirectory.If the documentation is in a new markdown file, I have added a link to this new file to the Docs folder
README.mdfile.