Utility\FilteredIteratorTest: split up test class + minor improvements to FilteredIterator #729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…icated test class
…onTest` ... as the remaining test relates directly to the serialization methods. Includes renaming the test method.
... by grouping the two `[__]unserialize()` methods together to make it more obvious that both have been implemented (the magic method for PHP 7.4+, the Serializable interface method for PHP < 7.4). Includes updating the documentation to reflect this as well.
As per the PHP documentation: > The Serializable interface > > Interface for customized serializing. > **Classes that implement this interface no longer support `__sleep()` and `__wakeup()`.** Ref: https://www.php.net/manual/en/class.serializable.php > Note: > If both `__unserialize()` and `__wakeup()` are defined in the same object, only `__unserialize()` will be called. `__wakeup()` will be ignored. Ref: https://www.php.net/manual/en/language.oop5.magic.php#object.unserialize Based on the above, the `wake_up()` method is redundant and has been for quite a while.
schlessera
approved these changes
May 9, 2022
schlessera
deleted the
feature/648-split-test-class-utility-filterediteratortest
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Utility\FilteredIteratorTest: split constructor specific tests to dedicated test class
Utility\FilteredIterator\FilteredIteratorTest: rename to
SerializationTest... as the remaining test relates directly to the serialization methods.
Includes renaming the test method.
FilteredIterator: improve method order
... by grouping the two
[__]unserialize()methods together to make it more obvious that both have been implemented (the magic method for PHP 7.4+, the Serializable interface method for PHP < 7.4).Includes updating the documentation to reflect this as well.
FilteredIterator: remove redundant method
As per the PHP documentation:
Ref: https://www.php.net/manual/en/class.serializable.php
Ref: https://www.php.net/manual/en/language.oop5.magic.php#object.unserialize
Based on the above, the
wake_up()method is redundant and has been for quite a while.FilteredIterator: add dedicated test for the current() functionality
Related to #648