-
-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update default minimum WP version #1237
Conversation
The build is running into the same fixer conflict issue as #1233. I'll look into that when I find some time and open a separate PR for that if needs be. (This one would need to be rebased afterwards) |
The minimum version should be three versions behind the latest WP release, so what with 4.9 having come out last week, it should now be 4.6.
a88b689
to
18146be
Compare
Rebased. I expect the build will now pass. |
@jrfnl I've run the tool, and it looks like there are some newly deprecated functions in 4.9. Here is a diff: feature/update-minimum-wp-version...feature/update-minimum-wp-version-diff The other differences I think are mostly because of the scanner's limitations (it doesn't detect class methods), but it might be good to double-check on some. |
Also: * Add alternatives for a couple of functions. * Annotated differences where the sniff is actually correct and WP Core is lagging behind.
@JDGrimes Thanks for that! I've re-verified all the differences.
Other than that, the four newly deprecated functions have of course been added, so this PR should be good to go AFAICS. |
Should this be merged as part of 0.15.0, or should it wait? |
@JDGrimes As 4.9 is out and it's a small change, I'd be ok with it to be merged in for 0.15.0. |
The minimum version should be three versions behind the latest WP release, so what with 4.9 having come out last week, it should now be 4.6.
@JDGrimes Want to run your deprecated function magic to see if we need to add functions/classes/parameters to the lists ?